Skip to content

Improve local setup with docker compose #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2020
Merged

Improve local setup with docker compose #18

merged 2 commits into from
Jan 13, 2020

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Jan 12, 2020 •
edited
Loading

change confluent/kafka to wurstmeister/kafka and update README.md.
If npm run start show error, please remove the wurstmeister/kafka and wurstmeister/zookeeper container and deploy docker again

maxceem
maxceem suggested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker setup works great.

There are few commands in README that don't work for me:

  1. .
    image

  2. .
    image

maxceem
maxceem approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this PR and fix the commands in README myself, the rest works good.

@maxceem maxceem changed the base branch from develop to feature/docker-setup-improve January 13, 2020 03:01
@maxceem maxceem changed the title change confluent/kafka to wurstmeister/kafka Improve local setup with docker compose Jan 13, 2020
@maxceem maxceem merged commit 3a2bcd8 into topcoder-platform:feature/docker-setup-improve Jan 13, 2020
@yoution
Copy link
Contributor Author

yoution commented Jan 13, 2020 via email

@yoution
Copy link
Contributor Author

yoution commented Jan 13, 2020

  1. first command work in my computer
    image
  2. for watch topic command I don't know how to resolve it

@yoution yoution deleted the feature/dockerupdate branch January 13, 2020 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxceem maxceem maxceem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoution @maxceem